Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Issue #1320: Added a bit of relative positioning to fix the help button... #1416

Merged
merged 1 commit into from Dec 24, 2012

Conversation

Projects
None yet
2 participants
Contributor

dainmiller commented Dec 21, 2012

... fixes alignment on (login/register/forgot password) pages.

This was a simple position: relative alignment fix, and it has been tested to work in the following browsers:

  • IE 8
  • IE 9
  • Firefox 13, 14, 15, 16(beta)
  • Safari 5
  • Chrome 15 - 23, and 24(beta)
  • Opera 10 - 12.10, and 12.11(beta)

Note: In certain cases margin-bottom doesn't work, and often it is bad practice to use a negative top margin in these cases to 'hack' margin-bottom to work. So what we did here was use position: relative, with a bottom value, this way we didn't have to do any hacks.

Dain Miller Issue #1320: Added a bit of relative positioning to fix the help butt…
…on alignment on (login/register/forgot password) pages.
5123a65

@ginatrapani ginatrapani added a commit that referenced this pull request Dec 24, 2012

@ginatrapani ginatrapani Merge pull request #1416 from CDainMiller/1320-help-button-height-fix
Issue #1320:  Relative positioning to fix the help button on login/reg/forgot password pages
Closes #1320
c991145

@ginatrapani ginatrapani merged commit c991145 into ThinkUpLLC:master Dec 24, 2012

Owner

ginatrapani commented Dec 24, 2012

Thanks so much for this, that was driving me crazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment