Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

374 isolated @ symbol and 373 initial .@username #543

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

suth commented Jan 8, 2011

This update fixes these two issues and greatly simplifies the replacement process.

Contributor

suth commented Jan 9, 2011

Fixed Twitter username link bugs

  • Doesn't link isolated @ symbols
  • Fixed links to usernames surrounded by parentheses
  • Fixed links to usernames starting with a .
  • Simplified the replacement of usernames using a regex
  • Added test cases for each to assert links are correct
  • Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831, Closed by 33f9831
Owner

ginatrapani commented Jan 9, 2011

Achievement unlocked! You fixed 4 issues with one regex. Nice work, and thanks! (I added a test case to assert all the different linking cases work as expected.)

unruthless pushed a commit to unruthless/ThinkUp that referenced this pull request Apr 27, 2011

Fixed Twitter username link bugs
* Doesn't link isolated @ symbols
* Fixed links to usernames surrounded by parentheses
* Fixed links to usernames starting with a .
* Simplified the replacement of usernames using a regex
* Added test cases for each to assert links are correct
* Closes #373, Closes #374, Closes #375, Closes #381, Closes #543

This issue was closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment