Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Singleton config #562

Closed
wants to merge 1 commit into from

2 participants

Piyush Mishra Gina Trapani
Piyush Mishra

unmarked issue: changed the config class constructor to private instead of public

Gina Trapani
Owner

Thank you for the pull request! I'll also make the update to Logger when I merge this.

Piyush Mishra

yay!!! my first commit to any opensource sw :)

Piyush Mishra

umm I just thought of this. did you mean I should do it? I can rebase and make the update in a minute but am not sure if it would show up in this pull request. should I make the changes and give you another pull request?

Piyush Mishra

Made the Config & Logger constructors private since they are singletons

Closed by 4bd27eb

Ruthie BenDor unruthless referenced this pull request from a commit in unruthless/ThinkUp
Piyush Mishra Made the Config & Logger constructors private since they are singletons
Closes #562
4bd27eb
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 21, 2011
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 webapp/_lib/model/class.Config.php
4 webapp/_lib/model/class.Config.php
View
@@ -53,11 +53,11 @@ class Config {
*/
var $config = array();
/**
- * Constructor
+ * Private Constructor
* @param array $vals Optional values to override file config
* @return Config
*/
- public function __construct($vals = null) {
+ private function __construct($vals = null) {
if ($vals != null ) {
$this->config = $vals;
} else {
Something went wrong with that request. Please try again.