Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip fields with missing enum types #7

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
2 participants
@alexheretic
Copy link
Contributor

commented May 7, 2019

This pr removes fields with enum types containing ::.

The build currently skips generation of enums containing ::, so this allows the built code to compile when they exist in the steam api's json. Ie the new code matches the existing:

for e in steam_api.enums {
    if e.enumname.contains("::") {
        continue;
    }
...

Maybe there's a better fix, this is just how I got it to compile.

@Thinkofname

This comment has been minimized.

Copy link
Owner

commented May 7, 2019

Looks fine to me. Seems the new steamworks sdk actually uses those enums now (guessing the new networking api?) so something will have to be worked on when those types are wrapped but this is fine for now. Thanks!

@Thinkofname Thinkofname merged commit ca4f721 into Thinkofname:master May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.