Change strategy for creating database #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use 'ensureDatabaseExists' flag on the migrate function. I _think_ this makes the API smaller/simpler. This implementation also checks whether the database exists before trying to create it, which means it _should_ work on readonly replicas. Fixes #57
ThomWright
force-pushed
the
ensure-exists
branch
from
e81e9e8 to
6a4bf77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use 'ensureDatabaseExists' flag on the migrate function.
I think this makes the API smaller/simpler.
This implementation also checks whether the database exists before
trying to create it, which means it should work on readonly
replicas.
Fixes #57