Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question / Can YearWeek and others implement Temporal? #115

Closed
proteus-russ opened this issue Dec 7, 2018 · 2 comments · Fixed by #165
Closed

Question / Can YearWeek and others implement Temporal? #115

proteus-russ opened this issue Dec 7, 2018 · 2 comments · Fixed by #165
Labels
Fixed RFE

Comments

@proteus-russ
Copy link

proteus-russ commented Dec 7, 2018 •
edited

I'm new to the java time API, I was wondering if there was a reason why YearWeek and similar don't implement Temporal. If you think it makes sense to do and a PR would be accepted, please let me know and I'll dig into it. Thank you.
@jodastephen
Copy link
Member

Seems reasonable. I've created a branch, but it still needs tests adding if you'd like to fork and PR?
https://github.com/ThreeTen/threeten-extra/commits/topic/year-week

@jodastephen jodastephen added the RFE label Dec 9, 2018
@Jaimies
Copy link
Contributor

Jaimies commented Nov 25, 2020

@jodastephen I have created a PR that adds the needed tests: #163.

@jodastephen jodastephen mentioned this issue Nov 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Fixed RFE
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make YearWeek implement Temporal ThreeTen/threeten-extra
3 participants
@jodastephen @proteus-russ @Jaimies