Skip to content

Loading…

Review use of caches #184

Closed
jodastephen opened this Issue · 2 comments

1 participant

@jodastephen
ThreeTen member

We need to find all the caches in JSR-310 and ensure that their use is acceptable and sensible. Caching needs in the JDK/JRE may also differ in the embedded version.

@jodastephen
ThreeTen member

We have caching as follows:

  • LocalTime holds a cache of each instance representing a whole hour
  • ZoneOffset holds a cache of all offset objects that are created (max cache size 129,601)
  • DateTimeTextProvider holds an cache of text by field/locale
  • Chronology holds a cache of chronologies
  • WeekFields holds a cache of instances
  • TzdbZoneRulesProvider and ZoneRulesProvider hold caches of time-zones
@jodastephen
ThreeTen member

The only concerning one AFAICT was ZoneOffset, but that now caches only offsets such as xx:00, xx:15, xx:30 and xx:45, not all offsets.

Open a separate issue if there is a problem,

@jodastephen jodastephen closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.