Rename Instant.toEpochMilli to toEpochMillis #300

Closed
RogerRiggs opened this Issue Apr 3, 2013 · 2 comments

Projects

None yet

2 participants

@RogerRiggs

It was observed that in most methods in 310 and in the JDK the names of methods use "millis" and not "milli". See Clock, Duration, etc for examples.
Rename toEpochMilli and ofEpochMilli to use the plural.

@jodastephen
ThreeTen member

This was deliberate. We also have LocalDate.ofEpochDay, LocalTime.ofNanoOfDay, LocalTime.ofSecondOfDay, LocalDateTime.ofEpochSecond and Instant.ofEpochSecond.

In general, we use singular for fields and plural for units.

I don't overly mind changing, but we'd have to identify every last case that needs changing for consistency.

@RogerRiggs

The motivation to change is not compelling and it would cause other changes. The current approach is self consistent and deliberate. Leave it as is.

@RogerRiggs RogerRiggs closed this Jun 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment