Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Decide/implement lenient parsing #65

Closed
jodastephen opened this Issue Aug 23, 2012 · 6 comments

Comments

Projects
None yet
2 participants
Owner

jodastephen commented Aug 23, 2012

Ensure that strict vs lenient parsing (and case sensitive vs insensitive) is suitable. Check that what it does is sensible.

Note that lenient parsing day of month 0 to the last day of the previous month is another question to be resolved.

Owner

jodastephen commented Aug 31, 2012

See also #73

Contributor

RichardWarburton commented Oct 5, 2012

Lenient parsing involves being able to set values outside the range of a field, eg October 36th. This would then be converted to November 5th. At the moment we don't have this functionality, only lowercase vs uppercase.

This issue is about making sure that its appropriate to add further functionality, for example October 36th.

@jodastephen jodastephen was assigned Oct 5, 2012

Owner

jodastephen commented Oct 17, 2012

The parseLenient setting currently does the following:

  • Lenient effectively ignores the SignStyle during parsing, and accepts both + and - as prefixes to numbers. Strict requires the SignStyle to be followed exactly.
  • Lenient ignores the TextStyle in parsing, accepting any matching text. Strict requires the TextStyle to match exactly.

Case sensitivity is controlled with a different setting (as they are orthogonal, notably strict for ISO parsing but ISO may want case sensitive or insensitive).

Owner

jodastephen commented Oct 17, 2012

It would make sense to extend lenient to cover some additional cases:

  • missing padding should be accepted when lenient
  • missing fraction digits should be accepted when lenient
  • missing number digits should be accepted when lenient (#73)

Also ensure that case sensitivity applies to other text-based parsing, such as time-zone and chronology.

@jodastephen jodastephen added a commit that referenced this issue Nov 29, 2012

@jodastephen jodastephen Fractional formatter changes
Alter pattern handling to remove letter f
Use letter S as fraction-of-second
Make parsing different for strict/lenient
Fixes #76
See #65
f68d751

@jodastephen jodastephen added a commit that referenced this issue Dec 3, 2012

@jodastephen jodastephen Better lenient parsing for fraction
See #65
0491d49
Owner

jodastephen commented Jan 28, 2013

Remaining item broken out to new issue. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment