Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend test cert validity to 2049 #91

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Oct 8, 2019

Extend test cert validity to 2049
to make tests pass in 2022

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.

Note: I tested that i586 builds still pass tests on 2037-12-01
so are not affected by the year 2038 bug yet.

to make tests pass in 2022

Background:
As part of my work on reproducible builds for openSUSE, I check
that software still gives identical build results in the future.
The usual offset is +15 years, because that is how long I expect
some software will be used in some places.
This showed up failing tests in our package build.

See https://reproducible-builds.org/ for why this matters.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Oct 8, 2019

Codecov Report

Merging #91 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #91   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files          35       35           
  Lines        3529     3529           
=======================================
  Hits         2853     2853           
  Misses        676      676

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4789af...1ef1876. Read the comment docs.

@ethe

This comment has been minimized.

Copy link
Member

ethe commented Oct 8, 2019

LGTM, thank you!

@ethe ethe merged commit cdb5b71 into Thriftpy:master Oct 8, 2019
4 checks passed
4 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Travis CI - Pull Request Build Passed
Details
codecov/patch Coverage not affected when comparing f4789af...1ef1876
Details
codecov/project 80.84% remains the same compared to f4789af
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.