New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mistake of arity when generating functions #123

Merged
merged 1 commit into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@Kraks
Contributor

Kraks commented Jan 24, 2018

The arity of generated function would be not correct if we split the string representation of tuple type by a comma and count the number, because the tuple may contain other type constructor that has multiple type arguments.
For example, a tupled function representation “Tuple2[Map[A,B], Int]” would be staged to “Function3” if simply splitted by comma and count the number.
This pull request fixes it by just extracting the number between "scala.Tuple" and the first left bracket "[".

@coveralls

This comment has been minimized.

coveralls commented Jan 24, 2018

Coverage Status

Coverage decreased (-0.01%) to 44.472% when pulling 7ddd4ce on Kraks:develop into 6f96a0c on TiarkRompf:develop.

@TiarkRompf

Thanks, LGTM.

@TiarkRompf TiarkRompf merged commit 361a806 into TiarkRompf:develop Jan 25, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment