SiteIcon uploader ought to have constraints #948

cdent opened this Issue Jul 10, 2012 · 1 comment


None yet

1 participant


The SiteIcon uploader in SpaceSettings suggests that the file to be uploaded be a small image but it will happily accept:

  • a gigantic image
  • a file which isn't an image (for example a javascript file)

Either of these result in undesirable behavior.


This is already done with the drag and drop version recently done by @colmjude. It appears there's no easy way to access the file's type if we want to continue to have the form just be a form. We haven't actually had a bunch of problems with this, so will leave it lie.

@cdent cdent closed this Aug 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment