Adjust ts.js to use tiddlyweb.status from /status.js#4
Merged
Conversation
Instead making an async call to to /status. This is a first step in lessening complexity in application code. See the statusjs branch (forthcoming) in tiddlyspace for comparison. Also, only do all that work for ts.initForSpace_ if we are in _space or _account. For things like backstage it is not needed. Obviously there are further ways to clean this up up, but I thought I'd start with this for review.
Contributor
Author
|
the branch at tiddlyspace: https://github.com/TiddlySpace/tiddlyspace/compare/statusjs |
bengillies
added a commit
that referenced
this pull request
Jul 3, 2012
Adjust ts.js to use tiddlyweb.status from /status.js
gimntut
pushed a commit
to gimntut/tiddlyspace
that referenced
this pull request
Apr 26, 2016
See: TiddlySpace/ts.js#4 The idea here is to use an adjusted ts.js that does not do an async call to /status as the first step in a hopefully many stepped process to lessen complexity and overhead in common tiddlyspace coding activities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead making an async call to to /status. This is a first step
in lessening complexity in application code. See the statusjs
branch (forthcoming) in tiddlyspace for comparison.
Also, only do all that work for ts.initForSpace_ if we are in _space
or _account. For things like backstage it is not needed. Obviously
there are further ways to clean this up up, but I thought I'd
start with this for review from @jdlrobson and @bengillies
Note: for a real review it's probably best to check this branch out and do a git diff -b as without -b it looks like a bunch of whitespace changes (there is an indention change). Apologies for my lack of tab/space discipline. It's quite likely what with the shift in participants I will get rid of the devil tabs any way, so if you can find it in your hearts to ignore that aspect of things in this review that would be great.