Markdown: Add code block button + enable shortcut #6689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmario
reviewed
May 11, 2022
| icon: $:/core/images/mono-block | ||
| caption: {{$:/language/Buttons/MonoBlock/Caption}} (Markdown) | ||
| description: {{$:/language/Buttons/MonoBlock/Hint}} | ||
| condition: [<targetTiddler>type[text/x-markdown]] |
There was a problem hiding this comment.
Condition should be like this: [<targetTiddler>type[text/x-markdown]] [<targetTiddler>type[text/markdown]] since both types are possible now. Also see: #6528
There was a problem hiding this comment.
OK, I have changed it.
|
Great stuff, thanks @MaxGyver83 |
MaxGyver83
deleted the
feature/enable-code-block-button-and-shortcut-in-markdown-tiddlers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the markdown plugin, you can enter fenced code blocks in markdown tiddlers but there is no button in the editor toolbar and the usual shortcut (ctrl-shift-M) doesn't work either.
This pull requests adds a code block button (same as for regular tiddlers) and by that, the shortcut works without further code changes.