Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery version validation fix #30

Merged
merged 1 commit into from Mar 7, 2017

Conversation

agustin-tiendanube
Copy link
Contributor

(parseFloat(jQuery.fn.jquery) < 1.7) is false when jQuery version is ≥ 1.10 because of literal comparison.

Copy link
Member

@lombo lombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@agustin-tiendanube agustin-tiendanube merged commit d9ee50e into master Mar 7, 2017
@nacho-tn nacho-tn deleted the jquery-version-validation-fix branch July 2, 2019 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants