Skip to content

Conversation

@gsakkis
Copy link
Contributor

@gsakkis gsakkis commented Nov 25, 2022

  • Change TileDBOpenSlide.__init__ to accept (open) TileDB image level arrays instead of opening & closing them on every read_region call.
  • Make TileDBOpenSlide a context manager for closing the image level arrays in a clean manner:
with TileDBOpenSlide.from_group_uri(uri) as t:
   ...

@gsakkis gsakkis requested review from ihnorton and ktsitsi November 25, 2022 14:19
@gsakkis gsakkis changed the base branch from main to gsa/sc-22596/test-ometiff-fileio-support November 25, 2022 14:20
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 lgtm

@gsakkis gsakkis changed the base branch from gsa/sc-22596/test-ometiff-fileio-support to main November 29, 2022 08:12
@gsakkis gsakkis merged commit 4e2d345 into main Nov 29, 2022
@gsakkis gsakkis deleted the gsa/tdbopenslide-context-manager branch November 29, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants