Add support for non empty domain var by name [ch1877] #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
approved these changes
May 7, 2020
gsvic
force-pushed
the
victorgiannakouris/ch1877/add-support-for-non-empty-domain-var-by-name
branch
2 times, most recently
from
9f00fc1 to
d99068d
Compare
Shelnutt2
approved these changes
May 7, 2020
| try (Domain domain = schema.getDomain()) { | ||
| long numDims = domain.getNDim(); | ||
| for (long dimIdx = 0; dimIdx < numDims; ++dimIdx) { | ||
| Dimension dimension = domain.getDimension(dimIdx); |
There was a problem hiding this comment.
Does the dimension need to be inside a try for the autoclosure?
There was a problem hiding this comment.
In fact no, this is a leftover from the old code. Fixed that.
gsvic
force-pushed
the
victorgiannakouris/ch1877/add-support-for-non-empty-domain-var-by-name
branch
from
d99068d to
78541dc
Compare
gsvic
deleted the
victorgiannakouris/ch1877/add-support-for-non-empty-domain-var-by-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.