Skip to content

Remove haswell #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 26, 2020
Merged

Remove haswell #200

merged 1 commit into from
Oct 26, 2020

Conversation

@gsvic
Copy link
Contributor

@gsvic gsvic commented Oct 26, 2020

No description provided.

@gsvic gsvic requested a review from Shelnutt2 October 26, 2020 14:00
Shelnutt2
Shelnutt2 reviewed Oct 26, 2020
View reviewed changes
Copy link
Member

@Shelnutt2 Shelnutt2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove the windows setting of CL: "/arch:AVX2" ?

@gsvic
Copy link
Contributor Author

gsvic commented Oct 26, 2020 •
edited
Loading

Do we need to remove the windows setting of CL: "/arch:AVX2" ?

@Shelnutt2 So far we have seen issues only in Unix-based systems (Linux and OSX) coming from our distributed frameworks (TileDB-Spark and TileDB-Presto), as we only build for Linux and OSX currently. So I believe we can leave the windows setting for now and consider removing it if we face any issue in the future.

@Shelnutt2
Copy link
Member

Shelnutt2 commented Oct 26, 2020

Do we need to remove the windows setting of CL: "/arch:AVX2" ?

@Shelnutt2 So far we have seen issues only in Unix-based systems (Linux and OSX) coming from our distributed frameworks (TileDB-Spark and TileDB-Presto), as we only build for Linux and OSX currently. So I believe we can leave the windows setting for now and consider removing it if we face any issue in the future.

Thanks for the details, agreed lets leave windows as is for now.

@gsvic gsvic merged commit 9c8bf19 into master Oct 26, 2020
@Shelnutt2 Shelnutt2 deleted the victorgiannakouris/remove_haswell branch December 4, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shelnutt2 Shelnutt2 Shelnutt2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gsvic @Shelnutt2