NULL support bindings #202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsvic
force-pushed
the
victorgiannakouris/null_support
branch
from
a69c219 to
c34a1a9
Compare
|
@gsvic I will take a look at this once the core PR is merged, hopefully next week. |
gsvic
force-pushed
the
victorgiannakouris/null_support
branch
3 times, most recently
from
dae5d6e to
0e8cc06
Compare
joe-maley
reviewed
Nov 12, 2020
gradle.properties
Outdated
| @@ -1,5 +1,5 @@ | |||
| TILEDB_GIT_REPOSITORY=https://github.com/TileDB-Inc/TileDB | |||
| TILEDB_GIT_TAG=2.1.2 | |||
| TILEDB_GIT_TAG=dev | |||
There was a problem hiding this comment.
Should we wait until we release 2.2 with null support?
Contributor
Author
There was a problem hiding this comment.
Yes, I agree. I changed the tag to dev just for the CI. So let's wait for the 2.2 release.
| public void testAttributeSetNullable() throws Exception { | ||
| try (Context ctx = new Context(); | ||
| Attribute a = new Attribute(ctx, "a2", Datatype.TILEDB_FLOAT32)) { | ||
| a.setNullable((short) 0); |
There was a problem hiding this comment.
there appears to be an indentation issue here
Contributor
Author
There was a problem hiding this comment.
I think that this is ok. If you look at it, the Attribute a = .. is inside the try parentheses (try (Context ctx = ... Attribute a = ...) similarly to an if () {} block. So that's why the a.setNullable (line 116) is positioned two tabs (\t) after the try (line 114).
What do you think?
gsvic
force-pushed
the
victorgiannakouris/null_support
branch
2 times, most recently
from
c8efcd6 to
49286a6
Compare
gsvic
force-pushed
the
victorgiannakouris/null_support
branch
from
49286a6 to
2eba444
Compare
gsvic
force-pushed
the
victorgiannakouris/null_support
branch
from
9e4359e to
2297da8
Compare
Shelnutt2
reviewed
Jan 27, 2021
| } | ||
| } | ||
|
|
||
| public int setNullable(short nullable) throws TileDBError { |
Shelnutt2
approved these changes
Jan 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.