Map (u)int64 indices and restore third dim when indexing #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #8355: Misleading error when array with int64 dim indexed with bare ints. |
ihnorton
reviewed
Feb 3, 2022
There was a problem hiding this comment.
One inline question.
Also, quick question about test coverage for this code path (only scanned test_tiledbarray so maybe I missed some) -- do we have the following somewhere?
- test of indexing with only
ion a 2D array? - test of indexing with only
ion a 1D array? If not, maybe add here?
|
I added another battery of tests on |
ihnorton
approved these changes
Feb 3, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes uses of the base layer we added via
selected_ranges()and adds mapping "automagic" mapping for (u)int64 dimensions, and restores the third dimension. Full generality is still available viaselected_ranges().