Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump curl to v7.64.1 #1240

Merged
merged 3 commits into from May 2, 2019
Merged

Bump curl to v7.64.1 #1240

merged 3 commits into from May 2, 2019

Conversation

@ihnorton
Copy link
Member

ihnorton commented May 1, 2019

Update curl version in order to get the following patch, which fixes use of HTTPS with S3 (via libcurl) in a static build, by allowing SSL feature checks to compile:

curl/curl@0616dfa

(in particular, this fixes use of S3 in the PyPI linux build)


For future reference, the way I found this was:

configure:25513: WARNING: SSL disabled, you will not be able to use HTTPS, FTPS, NTLM and more.
configure:25515: WARNING: Use --with-ssl, --with-gnutls, --with-polarssl, --with-cyassl, --with-nss, --with-schannel, --with-secure-transport, --with-mesalink or --with-amissl to address this.
ihnorton added 2 commits May 1, 2019
The following patch fixes usage of HTTPS with libcurl in a static build, by
allowing feature checks to compile:

curl/curl@0616dfa
@ihnorton ihnorton force-pushed the ihn/bump_curl_version branch from 51b0ec4 to 5b48cb4 May 1, 2019
I think this used to work incidentally thanks for a fallback to system
paths. However, with the version bump, curl config now validates that
the ssl headers are available in '$PREFIX/include', so we can only pass
'--with-ssl' when we control the prefix.

curl/curl@d353af0
@ihnorton

This comment has been minimized.

Copy link
Member Author

ihnorton commented May 1, 2019

I added a small AWSSDK fix for static build here to avoid multiple branches/CI runs.

@ihnorton ihnorton requested review from joe-maley and tdenniston May 1, 2019
@tdenniston tdenniston added this to the 1.6.0 milestone May 1, 2019
Copy link
Contributor

joe-maley left a comment

LGTM, thanks!

@jakebolewski

This comment has been minimized.

Copy link
Contributor

jakebolewski commented May 1, 2019

Is this a change we can backport?

@ihnorton ihnorton merged commit 193f604 into dev May 2, 2019
11 checks passed
11 checks passed
TileDB-Inc.TileDB Build #20190501.17 succeeded
Details
TileDB-Inc.TileDB (Windows VS2015) Windows VS2015 succeeded
Details
TileDB-Inc.TileDB (Windows VS2017) Windows VS2017 succeeded
Details
TileDB-Inc.TileDB (linux) linux succeeded
Details
TileDB-Inc.TileDB (linux_hdfs) linux_hdfs succeeded
Details
TileDB-Inc.TileDB (linux_s3) linux_s3 succeeded
Details
TileDB-Inc.TileDB (macOS) macOS succeeded
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ihnorton ihnorton added the backport label May 2, 2019
@ihnorton ihnorton modified the milestones: 1.6.0, 1.5.1 May 2, 2019
@ihnorton

This comment has been minimized.

Copy link
Member Author

ihnorton commented May 2, 2019

Yes: I've built this on 1.5.0 and tested read/write against AWS (no minio so didn't run the tests, but I expect they will be fine).

tdenniston added a commit that referenced this pull request May 16, 2019
The following patch fixes usage of HTTPS with libcurl in a static build, by
allowing feature checks to compile:

curl/curl@0616dfa

PR #1240

(cherry picked from commit 5ff53cf)
tdenniston added a commit that referenced this pull request May 16, 2019
tdenniston added a commit that referenced this pull request May 16, 2019
I think this used to work incidentally thanks for a fallback to system
paths. However, with the version bump, curl config now validates that
the ssl headers are available in '$PREFIX/include', so we can only pass
'--with-ssl' when we control the prefix.

curl/curl@d353af0

PR #1240

(cherry picked from commit 95d11ba)
@tdenniston tdenniston removed the backport label May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.