New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compute_mbr for var-sized dimensions #1732
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joe-maley
force-pushed
the
jpm/fix-compute-mbr-var
branch
2 times, most recently
from
July 21, 2020 19:45
50b4bbf
to
bff187e
Compare
In the write path, for sure the values are (or should be) in a contiguous buffer. |
stavrospapadopoulos
approved these changes
Jul 21, 2020
Shelnutt2
requested changes
Jul 22, 2020
There is a mistake in the logic of `compute_mbr` and `compute_mbr_var` that assumes that the var-sized cells in the value tile do not span more than one chunked buffer. If a var-sized cell contains 2 integer values, it is only true that the bytes for an individual integer value do not span a chunked buffer. The first integer value may be at the end of one chunked buffer and the second integer may be on the next chunked buffer. This could be easily fixed, but I also noticed that the write path (where these functions are called) guarantees that tile chunked buffers will always be contiguous. In this scenario, we can just revert both `compute_mbr` and `compute_mbr_var` to the logic before the chunked buffer patch (commit hash 4b4b502).
joe-maley
force-pushed
the
jpm/fix-compute-mbr-var
branch
from
July 22, 2020 12:47
bff187e
to
56d0489
Compare
Shelnutt2
approved these changes
Jul 22, 2020
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release-2.0.7 release-2.0.7
# Navigate to the new working tree
cd .worktrees/backport-release-2.0.7
# Create a new branch
git switch --create backport-1732-to-release-2.0.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick 9d7753249b7a1470e666e2520013f773322e9921
# Push it to GitHub
git push --set-upstream origin backport-1732-to-release-2.0.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release-2.0.7 Then, create a pull request where the |
Shelnutt2
pushed a commit
that referenced
this pull request
Jul 22, 2020
There is a mistake in the logic of `compute_mbr` and `compute_mbr_var` that assumes that the var-sized cells in the value tile do not span more than one chunked buffer. If a var-sized cell contains 2 integer values, it is only true that the bytes for an individual integer value do not span a chunked buffer. The first integer value may be at the end of one chunked buffer and the second integer may be on the next chunked buffer. This could be easily fixed, but I also noticed that the write path (where these functions are called) guarantees that tile chunked buffers will always be contiguous. In this scenario, we can just revert both `compute_mbr` and `compute_mbr_var` to the logic before the chunked buffer patch (commit hash 4b4b502). Co-authored-by: Joe Maley <joe@tiledb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a mistake in the logic of
compute_mbr
andcompute_mbr_var
thatassumes that the var-sized cells in the value tile do not span more than one
chunked buffer. If a var-sized cell contains 2 integer values, it is only true
that the bytes for an individual integer value do not span a chunked buffer.
The first integer value may be at the end of one chunked buffer and the second
integer may be on the next chunked buffer.
This could be easily fixed, but I also noticed that the write path (where these
functions are called) guarantees that tile chunked buffers will always be
contiguous. In this scenario, we can just revert both
compute_mbr
andcompute_mbr_var
to the logic before the chunked buffer patch (commit hash4b4b502).