Explicitly find and link with fmt.

[josephwinston]

I used the link library instead of the form for the header only.

[ihnorton]

Hi @josephwinston, thanks for the contribution. Could you please clarify the issue that this PR resolves?

I suspect this may be fixing the situation of

• spdlog is installed locally
• with fmt library built separately

If that is the case, rather than adding this in tiledb/CMakeLists.txt, we likely need to improve the logic in FindSpdlog.cmake to

• check for the correct transitive exports (depending on how the library was built)
• find/add fmt there if it is missing.

That way the linkage logic stays contained to the target that needs it, which should resolve the continuous integration failures here (spdlog is not available in our CI images, so it builds from source and automatically links fmt).

[josephwinston]

I bet you are correct. Let me see what is happening in the spdlog login.

…

On Aug 13, 2020, 1:37 PM -0500, Isaiah Norton ***@***.***>, wrote: Hi @josephwinston, thanks for the contribution. Could you please clarify the issue that this PR resolves? I suspect this may be fixing the situation of • spdlog is installed locally • with fmt library built separately" If that is the case, rather than adding this in tiledb/CMakeLists.txt, we likely need to improve the logic in FindSpdlog.cmake to • check for the correct transitive exports (depending on how the library was built) • find/add fmt there if it is missing. That way the linkage logic stays contained to the target that needs it, which should resolve the continuous integration failures here (spdlog is not available in our CI images, so it builds from source and automatically links fmt). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[josephwinston]

see Add link with fmt if existing spdlog is found and fmt exists #1770

…

On Aug 13, 2020, 3:14 PM -0500, Jody ***@***.***>, wrote: I bet you are correct. Let me see what is happening in the spdlog login. On Aug 13, 2020, 1:37 PM -0500, Isaiah Norton ***@***.***>, wrote: > Hi @josephwinston, thanks for the contribution. Could you please clarify the issue that this PR resolves? > I suspect this may be fixing the situation of > > • spdlog is installed locally > • with fmt library built separately" > > If that is the case, rather than adding this in tiledb/CMakeLists.txt, we likely need to improve the logic in FindSpdlog.cmake to > > • check for the correct transitive exports (depending on how the library was built) > • find/add fmt there if it is missing. > > That way the linkage logic stays contained to the target that needs it, which should resolve the continuous integration failures here (spdlog is not available in our CI images, so it builds from source and automatically links fmt). > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or unsubscribe.

[joe-maley]

Closing in favor of #1770