Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added object libraries: baseline, buffer, thread_pool #2629

Merged
merged 3 commits into from Nov 29, 2021

Conversation

eric-hughes-tiledb
Copy link
Contributor

Taking advantage of CMake 3.21, this PR creates a few new units using object libraries. The small proof-of-concept success here is that the thread_pool unit test target is linked simply to the (new) baseline unit without any other explicit dependencies.


TYPE: IMPROVEMENT
DESC: Added object libraries: baseline, buffer, thread_pool

@eric-hughes-tiledb eric-hughes-tiledb marked this pull request as ready for review November 19, 2021 00:17
@eric-hughes-tiledb
Copy link
Contributor Author

Need copyright notices. Will update

Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cruft nit, otherwise LGTM.

FWIW, when I tried this out here I was able to remove the gather_sources setup.

tiledb/sm/CMakeLists.txt Show resolved Hide resolved
@eric-hughes-tiledb eric-hughes-tiledb force-pushed the eh/introduce-object-libraries-into-build branch from 919c277 to 029ce65 Compare November 29, 2021 16:42
@eric-hughes-tiledb
Copy link
Contributor Author

Force-pushed rebase to dev

@Shelnutt2 Shelnutt2 merged commit a997f3a into dev Nov 29, 2021
@Shelnutt2 Shelnutt2 deleted the eh/introduce-object-libraries-into-build branch November 29, 2021 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants