Array Schema should serialize name in cap'n proto #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #12642: Serialize array schema name in cap'n proto. |
|
@dhoke4tdb would you mind regenerating the windows cap'n proto files when you have some time next week? |
Shelnutt2
force-pushed
the
sethshelnutt/sc-12642/serialize-array-schema-name-in-cap-n-proto
branch
from
1332842
to
5fcd3a5
Compare
Shelnutt2
requested review from
dhoke4tdb
and removed request for
stavrospapadopoulos
Shelnutt2
force-pushed
the
sethshelnutt/sc-12642/serialize-array-schema-name-in-cap-n-proto
branch
2 times, most recently
from
7a01ce8
to
61e89a1
Compare
The cap'n proto serialization should include the array schema name. This allows completeness when building the array schema object and use in the array_schemas_all unordered_map after deserialization.
Shelnutt2
force-pushed
the
sethshelnutt/sc-12642/serialize-array-schema-name-in-cap-n-proto
branch
from
61e89a1
to
d3efe1e
Compare
bdeng-xt
approved these changes
Dec 21, 2021
Shelnutt2
deleted the
sethshelnutt/sc-12642/serialize-array-schema-name-in-cap-n-proto
branch
github-actions bot
pushed a commit
that referenced
this pull request
Dec 21, 2021
The cap'n proto serialization should include the array schema name. This allows completeness when building the array schema object and use in the array_schemas_all unordered_map after deserialization.
Shelnutt2
added a commit
that referenced
this pull request
Dec 21, 2021
The cap'n proto serialization should include the array schema name. This allows completeness when building the array schema object and use in the array_schemas_all unordered_map after deserialization. Co-authored-by: Seth Shelnutt <seth@tiledb.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cap'n proto serialization should include the array schema name. This allows completeness when building the array schema object and use in the
array_schemas_allunordered_map after deserialization.TYPE: IMPROVEMENT
DESC: Array Schema name should be included with cap'n proto serialization