Feature/add init secretes#85
Merged
Merged
Conversation
Remove opencloud init from startup command. All secrets and UUIDs are now injected directly as runtime ENV vars from Kubernetes Secrets. This eliminates the need for a custom binary or config persistence. Changes: - Remove opencloud init from container entrypoint - init-secrets.yaml: add 5 UUIDs alongside 11 secrets (16 keys total) - deployment.yaml: inject 24 runtime ENV vars (secrets, UUIDs, LDAP bind passwords, IDM admin, service account IDs) - README.md: update Init Secrets section Tested with upstream opencloudeu/opencloud-rolling:latest image. All 5 pods (opencloud, keycloak, collabora, collaboration, tika) start and run successfully without opencloud init. Closes: opencloud-eu/opencloud#2483
There was a problem hiding this comment.
Pull request overview
This PR introduces “init secrets” for OpenCloud’s internal service credentials so that credentials can be injected deterministically via a Kubernetes Secret, and removes the runtime opencloud init step from the main container startup.
Changes:
- Add
opencloud.initSecrets.existingSecretvalue to allow using a pre-created Secret (otherwise auto-generate). - Add a new
*-initSecret template that generates/persists internal credentials usinglookup. - Inject the init-secret values into the OpenCloud Deployment via environment variables; switch probes from HTTP
/healthto TCP socket checks.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| charts/opencloud/values.yaml | Adds configuration for selecting an existing init Secret. |
| charts/opencloud/templates/opencloud/init-secrets.yaml | New template to create/persist internal init credentials in a Secret. |
| charts/opencloud/templates/opencloud/deployment.yaml | Removes opencloud init startup, injects init credentials via env vars, and changes probes to TCP. |
| charts/opencloud/README.md | Documents the new init secrets option and required keys. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced May 16, 2026
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of running
opencloud init, we can inject all secrets via ENVs from a secret to avoid the need of an additional config volumeIssue: #57