TimWolla
Follow
Pinned
3,100 contributions in the last year
Activity overview
Contribution activity
September 2023
Created 243 commits in 22 repositories
Created 1 repository
Created a pull request in php/php-src that received 29 comments
Reimplement php_round_helper() using modf()
This change makes the implementation much easier to understand, by explicitly handling the various cases.
It fixes rounding for 0.49999999999999994,…
+183
−18
•
29
comments
Opened 40 other pull requests in 13 repositories
WoltLab/WCF
8
merged
1
closed
1
open
- Update composer dependencies
- Entirely hide the search for guests if login is forced
- PoC: Fix handling of comment notifications
- Add Mailbox::getAddressForMailto()
- Gracefully handle broken preload JSON
- Properly handle malformed URIs in HtmlOutputNodeA
-
Migrate from DomChangeListener to
wheneverFirstSeen()for Date/Picker - Fix catastrophic backtracking in FileUtil::LINK_REGEX
- Reduce abuse potential of link values in UGC
- Update test.php
php/php-src
2
open
4
merged
WoltLab/com.woltlab.wcf.conversation
6
merged
- Fix opening draft conversations
- Correctly update the participant counter when removing an invisible participant
- Fix adding participants that previously participated invisibly
- Fix Conversation::hasOtherParticipants()
- Show warning when replying as an invisible participant
- Properly suppress modification log entries for invisible participants
php/doc-en
6
merged
-
crypt: Do not reference
md5() - crypt: Remove examples showcasing bad practices
- password_verify: Update the example hash to actually be consistent wi…
- password_needs_rehash: Fix example
- password_hash: Update the caution note about providing a salt
- password_hash: Update script to generate cost recommendations
paragonie/constant_time_encoding
3
merged
laminas/laminas-httphandlerrunner
2
merged
laminas/laminas-progressbar
1
open
maennchen/ZipStream-PHP
1
closed
wbbaddons/Tims-PackageServer
1
merged
WoltLab/com.woltlab.wcf.legalNotice
1
merged
PHPCSStandards/PHPCSExtra
1
open
docker-library/php
1
open
WoltLab/com.woltlab.wcf.exporter
1
merged
Reviewed 40 pull requests in 10 repositories
php/php-src
15 pull requests
- RFC: Integer rounding
- Unify type juggling in math.c
- FIX GH-12143: Remove pre-rounding
- fix random_bytes(0) and Random\Randomizer::getBytes(0)
- round(): Validate the rounding mode
- Use __builtin_unreachable() for ZEND_UNREACHABLE
-
Reimplement
php_round_helper()usingmodf() - Fix #[Override] on traits overriding a parent method without a matching interface
- Fix GH-12143: Improved handling of adjusting result digits
- Upload callgrind profile to GA
- Show the integer size in phpinfo()
- A new PHP JIT implementation based on IR JIT framework
- Fix #12143: Improve precision of rounding for FP numbers
- Add 4 new rounding modes to round() function
- Add DOMNode::compareDocumentPosition()
php/doc-en
11 pull requests
- Document str_increment() and str_decrement()
-
Add documentation for the
Spoofchecker::setRestrictionLevelmethod - PHP 8.3 migration guide.
- Clarify that the constructor is not called with classes registered via registerNodeClass
- Copy and modify mb_str_pad from str_pad
-
Remove
session_registerreferences - Synchronize predefined constants with stubs - part 2
- Added syntax highlighting for currentdirectory in 'Using Namespace' page
- Remove reference to generating "Flash" movies
-
Wrap output string in
literal - Wrap example output in CDATA
WoltLab/WCF
7 pull requests
- Google maps Geocoding typing fix
- Use the exported typings of the editor
- Enable the experimental upgrade to 6.0
- Detect paid updates in the Plugin-Store during the process
- Add a license page to install WoltLab and Plugin-Store products
- Implement a helper to prevent the parallel execution of callbacks
-
Prevent concurrent
clickevent while the callback is still loading
laminas/laminas-progressbar
1 pull request
php/web-php
1 pull request
WoltLab/com.woltlab.wcf.conversation
1 pull request
ThePHPF/thephp.foundation
1 pull request
FakerPHP/Faker
1 pull request
PHPCSStandards/PHPCSExtra
1 pull request
docker-library/php
1 pull request
Created an issue in php/php-src that received 37 comments
Incorrect round($num, 0, PHP_ROUND_HALF_UP) result for $num = 1.4999999999999998 / 4503599627370495.5
Updated description:
<?php
$number = 0.49999999999999994;
var_dump($number, round($number, 0, PHP_ROUND_HALF_UP)); $number = 1.4999999999999998;
va…
37
comments