Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes Requested for AppCenter: Don't use other apps' private API #64

Closed
cassidyjames opened this issue Jan 20, 2020 · 1 comment
Closed
Assignees

Comments

@cassidyjames
Copy link

cassidyjames commented Jan 20, 2020

This seems really clever, but relying on other apps' private API (i.e. their GSettings) is unreliable and error-prone. We have amended the Technical Publishing Requirements to include:

Your app must not attempt to modify other apps or system programs. Your app should not rely on other apps' GSettings, as these are considered internal/private API for those apps.

https://github.com/Timecraft/JS_Test/blob/eb4d66955b4d63b37134c86305b2a1a1be1da5b6/src/Views/SourceView.vala#L67-L94

@cassidyjames cassidyjames changed the title Changes Requested for AppCenter: Don't use other apps Changes Requested for AppCenter: Don't use other apps' private API Jan 20, 2020
@Timecraft
Copy link
Owner

Understood. Marking this with #8, and modifying it to reflect this. I will completely restructure JS Test's GSettings to be self-contained. Thanks much, sir!

@Timecraft Timecraft self-assigned this Jan 21, 2020
Timecraft added a commit that referenced this issue Jan 21, 2020
Release v0.1.0
Fixes issue #64, #8, and #65.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants