Skip to content

Conversation

@triceo
Copy link
Collaborator

@triceo triceo commented Aug 25, 2025

No description provided.

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
65.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

This comment was marked as outdated.

@triceo triceo requested a review from Copilot August 25, 2025 10:54
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes nullability annotations around the SolutionManager by migrating from @NonNull to @NullMarked annotation strategy and correcting parameter nullability declarations.

  • Replaces @NonNull annotations with @NullMarked class-level annotations for better null safety defaults
  • Corrects proposition function parameter types to allow nullable return values in recommendation APIs
  • Fixes equals/toString implementations to handle null values properly in MutableReference

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
MutableReference.java Adds null safety annotations and fixes equals/toString to handle null values
RecommendationConstructor.java Updates interface to use @NullMarked and allow nullable result parameter
DefaultSolutionManager.java Migrates from @nonnull to @NullMarked and fixes score comparison logic
DefaultRecommendedFit.java Updates record to use @NullMarked instead of @nonnull
DefaultRecommendedAssignment.java Updates record to use @NullMarked instead of @nonnull
AssignmentProcessor.java Adds null safety and fixes resource management with try-with-resources
Assigner.java Updates to @NullMarked and adds null check for lookUpWorkingObject result
ShadowVariableUpdateHelper.java Adds @NullMarked and improves null safety with Objects.requireNonNull
SolutionManager.java Interface migration from @nonnull to @NullMarked with corrected parameter types
RecommendedFit.java Adds @NullMarked annotation
RecommendedAssignment.java Updates interface to use @NullMarked and fixes comment typo

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@triceo triceo merged commit 1a86e96 into TimefoldAI:main Aug 25, 2025
83 of 97 checks passed
@triceo triceo deleted the nullability branch August 25, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SolutionManager.recommendAssignment() incorrect @NonNull annotation

2 participants