Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upSpine's batch dropping seems erroneous. #230
Comments
This comment has been minimized.
This comment has been minimized.
Fixed with #231 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spines drop batches when their
advance_frontier
reaches the empty set. This has a few flaws, however:read_upper()
to indicate how far along the trace has progressed. In principle one can announce that they don't care about times, but still read fromread_upper()
for some reason.I'm not aware of settings in which a trace has its frontier advanced to the empty frontier, but is not itself dropped. We could plausibly just remove the eager dropping of batches, and try and reconstruct which mode of execution holds on to more memory than it is supposed to, and track down whichever villains are holding on to traces the cannot read out of.