Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Cross empty batches better #220
This PR attempts to fix #219 which observes memory leaks if data are not inserted. What seems to have happened is that the logic for spanning empty batches erroneously started from the upper limit of batches, where it should have started from the lower limit of batches. This was everywhere correct except when the first batch is empty, in that we would fail to see it.
In addition, both
Probably around then. I don't recall which features landed when, but empty batches had some work done in the 0.9 to 0.10 transition. Resources got stuck less (previously, memory leak on all empty intervals) but apparently the fix had issues. It may just have been different settings where the leaks happened (but the definitely happened before).