Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require arrangement sharing to communicate frontier changes. #243

Merged

Conversation

@frankmcsherry
Copy link
Member

frankmcsherry commented Jan 7, 2020

This PR requires that an arrangement's enter_at method takes a method to invert timestamps, so that frontier statements about the wrapper trace can be communicated back to the wrapped trace.
This method requires some care, but for the moment you probably shouldn't be using these methods without knowing about what is going on here; we could hope for a future interface that is clearer and less error prone.

This PR requires that an arrangement's `enter_at` method takes a method to invert timestamps, so that frontier statements about the wrapper trace can be communicated back to the wrapped trace.
This method requires some care, but for the moment you probably shouldn't be using these methods without knowing about what is going on here; we could hope for a future interface that is clearer and less error prone.
@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Jan 7, 2020

This fixes #242 and #234

@ryzhyk

This comment has been minimized.

Copy link
Contributor

ryzhyk commented Jan 7, 2020

It looks like f8f80fa broke dogs^3, which still expects minimum to be a member of Lattice, so cargo build fails in dogsdogsdogs.

@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Jan 7, 2020

Weird. I guess I failed to cargo update or something, not sure what (things were working locally on commit). It now seems to build for me (corrected examples too), but my confidence is shaken!

@frankmcsherry frankmcsherry merged commit 34d4fc5 into TimelyDataflow:master Jan 7, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.