Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the `Default` requirement from keys. #245

Merged
merged 1 commit into from Jan 10, 2020

Conversation

@frankmcsherry
Copy link
Member

frankmcsherry commented Jan 10, 2020

This PR removes the requirement that keys in lookup_map implement the Default trait.
The implementation was required to get access to instances to re-use in key extraction, but we can instead ask the caller to supply the instances themselves; when a type implements Default this is especially easy.
The constraint is only changed on lookup_map and not the count, propose, or validate methods.

This PR removes the requirement that keys in `lookup_map` implement the `Default` trait.
The implementation was required to get access to instances to re-use in key extraction, but we can instead ask the caller to supply the instances themselves; when a type implements `Default` this is especially easy.
The constraint is only changed on `lookup_map` and not the `count`, `propose`, or `validate` methods.
@frankmcsherry frankmcsherry merged commit fbea6a8 into TimelyDataflow:master Jan 10, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.