New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequencer does not retain order for concurrent inserts #223

Closed
frankmcsherry opened this Issue Feb 3, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@frankmcsherry
Copy link
Member

frankmcsherry commented Feb 3, 2019

The Sequencer does not respect the order elements are pushed, in the case that the worker collects a batch of elements at one time. Instead, they are sorted by whatever Ord implementation they have. Instead, the implementation should probably maintain another usize for local sequence number, so that the order pushed by each worker is reflected in the results.

@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Feb 3, 2019

@comnik be wary of this; it bit me when I created and then used an input collection in the same batch. It seems like a not so hard fix, so I should be able to get something out pretty quick.

@comnik

This comment has been minimized.

Copy link
Contributor

comnik commented Feb 4, 2019

This should be solved with #224, right?

@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Feb 4, 2019

Fixed by #224!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment