Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication: coalesce counters #243

Open
frankmcsherry opened this Issue Mar 5, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@frankmcsherry
Copy link
Member

frankmcsherry commented Mar 5, 2019

In communication/src/allocator/counters.rs the two Pushers counters should be able to coalesce pushed counts, rather than introduce each count as it happens. This requires that all code paths call done() on their pushers (or push a None item), which does not appear to currently be the case.

My recollection is that input is the ergonomically annoying case, where a user currently expects an input type that they can interact with without needing to signal "done-ness". A bit more discipline here (and perhaps some code breaks) should provide more clarity about when an input's output streams should propagate a done() signal (perhaps when the operator is executed; perhaps when the user says, perhaps something else entirely).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.