Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: a little detail #272

Closed
rasa200 opened this issue May 28, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@rasa200
Copy link

commented May 28, 2019

Hi there!!! (Thanks for the great initiative!!)

I was reading the documentation, the mdbook in fact, and in the "Iteration" subsection, inside "Advance Timely Dataflow", in the first code there is, you can note that there is a line missing in the code:
.branch_when(|t| t < &100).1

This is in the documentation of the feedback function (that is why I found it). Maybe you want to put it also in the mdbook :)

That's all!!
Cheers!!

@frankmcsherry

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Absolutely correct! For historical reasons, it used to be built in to the feedback operator, but is no more. I'll put together a fix!

@frankmcsherry

This comment has been minimized.

Copy link
Member

commented May 28, 2019

Thanks very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.