Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shutdown logging #241

Merged
merged 2 commits into from Mar 5, 2019

Conversation

Projects
None yet
2 participants
@frankmcsherry
Copy link
Member

frankmcsherry commented Mar 1, 2019

This WIP PR adds logging related to operator and dataflow shutdown. Right now the two are unified, as the creation of a dataflow is also logged as an OperatesEvent. Perhaps they could be broken apart to help out folks, but for the moment no.

cc @comnik

frankmcsherry added some commits Mar 1, 2019

@frankmcsherry

This comment has been minimized.

Copy link
Member Author

frankmcsherry commented Mar 5, 2019

This PR is not especially well tested (i.e. not confirmed that we capture all shutdown events) but merging it is probably the right way forward to testing (it should not break existing code, and may only be incomplete for uses of the new code).

@frankmcsherry frankmcsherry merged commit b26bd6e into master Mar 5, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@frankmcsherry frankmcsherry deleted the shutdown_logging branch Mar 5, 2019

@comnik

This comment has been minimized.

Copy link
Contributor

comnik commented Mar 11, 2019

I can at least verify now that shutdown events are issued for the expected set of operates whenever I use the shiny new arrangement shutdown buttons. Satisfying to see :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.