Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Builder simplification #276

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@frankmcsherry
Copy link
Member

commented Jul 9, 2019

This PR simplifies the operator builder pattern to use fewer and simpler closures to define an operator.

Previously, an operator was defined by two closures, "pull internal progress" and "push external progress" as these two methods were managed separately by subgraphs. They have since been unified into one method that does both (and maintains some invariants). The single method now takes a single argument which is their unified state (a mutable reference to the SharedProgress object that exchanges progress state between operator and scope, and whose contents define the contract between the two).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.