Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Export TcpBuilder construction #292

Merged
merged 2 commits into from Sep 6, 2019

Conversation

@frankmcsherry
Copy link
Member

commented Sep 4, 2019

This PR is the first steps in making a la carte construction of channel allocators from TCP connections easier. I expect this to be a bit of an iterative process where we learn about the next painful hunk of code that needs to be copy/paste'd and then split that open too.

cc @benesch

@benesch
Copy link
Contributor

left a comment

Yeah, looks like this should work nicely. Thanks, @frankmcsherry!

@benesch

This comment has been minimized.

Copy link
Contributor

commented Sep 5, 2019

Pushed up a commit to MaterializeInc/materialize#424 as proof!

@benesch
benesch approved these changes Sep 6, 2019
Copy link
Contributor

left a comment

🚢

@TimelyDataflow TimelyDataflow deleted a comment from IW00DB Sep 6, 2019

@frankmcsherry frankmcsherry merged commit 0d5dfae into TimelyDataflow:master Sep 6, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.