Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flushing #305

Merged
merged 2 commits into from Nov 5, 2019

Conversation

@frankmcsherry
Copy link
Member

frankmcsherry commented Nov 5, 2019

This PR reduces log flushing in timely dataflow. In particular, it reduces use of .clone() which invariably results in Logger::drop being called, which flushes. Even when flushed, we attempt to re-allocate buffers less often, by intercepting empty buffers and using Vec::new() instead.

cc @umanwizard

@frankmcsherry frankmcsherry merged commit 939b215 into master Nov 5, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.