Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve `is_acyclic`. #312

Merged
merged 2 commits into from Nov 19, 2019

Conversation

@frankmcsherry
Copy link
Member

frankmcsherry commented Nov 19, 2019

The method to test acyclicity used to maintain graph structure in a hash map of vectors, which resulted in a fair amount of allocation. We already had the graph structure, but it required a bit of interpretation (constructing from internal summaries, and restricting to those with default timestamp actions). Using this data instead results in less memory churn.

The method to test acyclicity used to maintain graph structure in a hash map of vectors, which resulted in a fair amount of allocation. We already had the graph structure, but it required a bit of interpretation (constructing from internal summaries, and restricting to those with default timestamp actions). Using this data instead results in less memory churn.
@frankmcsherry frankmcsherry merged commit 2b2a777 into master Nov 19, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.