{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":614453040,"defaultBranch":"android10-rk3399","name":"rockchip-android-system-ashmemd","ownerLogin":"TinkerBoard-Android","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2023-03-15T16:01:30.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/71118240?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1678933710.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"540d579f3079b1796414f12118632c6adc9387e3","ref":"refs/heads/android10-rk3399","pushedAt":"2023-03-15T16:01:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"asus-leslieyu","name":"Leslie Yu","path":"/asus-leslieyu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/58215206?s=80&v=4"},"commit":{"message":"Reland 'Check /dev/binder access before calling defaultServiceManager()'\n\nVendor processes do not have access to /dev/binder. Calling\ndefaultServiceManager() without RW permission will crash the process\nwith error message \"Binder driver could not be opened.  Terminating.\"\n\nNormally, VNDK version of libcutils.so would not have the codepath of\nashmemd. However, on non-VNDK this codepath is exercised.\n\nWe check if the current process has permissions to /dev/binder before\ncalling defaultServiceManager() to avoid crashing. The calling code in\nlibcutils.so handles inability to connect ashmemd correctly. It will\nfall back to opening /dev/ashmem directly. Vendor code should already\nhave permissions for that.\n\nThis SELinux denial shows which permissions need to be checked for:\navc: denied { read write } for name=\"binder\" dev=\"tmpfs\" ino=5570\nscontext=u:r:hal_sensors_default:s0 tcontext=u:object_r:binder_device:s0\ntclass=chr_file permissive=0\n\nNote that the problem only manifests on non-VNDK devices.\n\nBug: 129073672\nTest: ashmemd_test\nTest: VtsHalSensorsV1_0TargetTest\n--gtest_filter=SensorsHidlTest.AccelerometerAshmemDirectReportOperationNormal\nTest: atest CtsOsTestCases:android.os.cts.SeccompTest#testIsolatedServicePolicy\nChange-Id: I23bef7986298811ce2bd84c3fdc9c9e22837c368\nMerged-In: I23bef7986298811ce2bd84c3fdc9c9e22837c368\n(cherry picked from commit febe203d835f89eede3979e44bb80b2cda523047)","shortMessageHtmlLink":"Reland 'Check /dev/binder access before calling defaultServiceManager()'"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAADBCJJbQA","startCursor":null,"endCursor":null}},"title":"Activity · TinkerBoard-Android/rockchip-android-system-ashmemd"}