Check if device can have extension before accessing them

Tinkerforge · Oct 11, 2016 · 23133fe · 23133fe
1 parent c6d8975
commit 23133fe
Showing 1 changed file with 15 additions and 14 deletions.
diff --git a/src/brickv/flashing.py b/src/brickv/flashing.py
@@ -1269,20 +1269,21 @@ def get_color_for_device(device):
                             item.setData(color, Qt.BackgroundRole)
                         parent[0].appendRow(child)
 
-                for ext in device_info.extensions:
-                    if device_info.extensions[ext]:
-                        child = [QStandardItem(ext.capitalize() + ': ' + device_info.extensions[ext].name),
-                                 QStandardItem(''),
-                                 QStandardItem(get_version_string(device_info.extensions[ext].firmware_version_installed)),
-                                 QStandardItem(get_version_string(device_info.extensions[ext].firmware_version_latest))]
-
-                        color, update = get_color_for_device(device_info.extensions[ext])
-                        if update:
-                            is_update = True
-                        for item in child:
-                            item.setFlags(item.flags() & ~Qt.ItemIsEditable)
-                            item.setData(color, Qt.BackgroundRole)
-                        parent[0].appendRow(child)
+                if device_info.can_have_extension:
+                    for ext in device_info.extensions:
+                        if device_info.extensions[ext]:
+                            child = [QStandardItem(ext.capitalize() + ': ' + device_info.extensions[ext].name),
+                                     QStandardItem(''),
+                                     QStandardItem(get_version_string(device_info.extensions[ext].firmware_version_installed)),
+                                     QStandardItem(get_version_string(device_info.extensions[ext].firmware_version_latest))]
+
+                            color, update = get_color_for_device(device_info.extensions[ext])
+                            if update:
+                                is_update = True
+                            for item in child:
+                                item.setFlags(item.flags() & ~Qt.ItemIsEditable)
+                                item.setData(color, Qt.BackgroundRole)
+                            parent[0].appendRow(child)
 
             elif device_info.type == 'tool' and 'Brick Viewer' in device_info.name:
                 parent = [QStandardItem(device_info.name),