Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unexpected "Caps at start of sentences" #9

Closed
mogsdad opened this issue Oct 8, 2015 · 4 comments
Closed

Unexpected "Caps at start of sentences" #9

mogsdad opened this issue Oct 8, 2015 · 4 comments
Assignees
@mogsdad
Labels
bug

Comments

@mogsdad
Copy link
Collaborator

mogsdad commented Oct 8, 2015

This rule fires when there is no need for it. For example, original revision of this answer.

We've discussed this before, and I'd figured it was due to question titles, but that's obviously not the case with answers.
@mogsdad mogsdad added the bug label Oct 8, 2015
@mogsdad mogsdad self-assigned this Oct 8, 2015
@mogsdad
Copy link
Collaborator Author

mogsdad commented Oct 8, 2015

Got it! A blank line was being changed to '', which was detected as a change, causing the replacement count to increment.

mogsdad added a commit that referenced this issue Oct 8, 2015
@mogsdad
Fix issue #9
3a08062 
[Unexpected "Caps at start of sentences"](#9)
mogsdad added a commit that referenced this issue Oct 8, 2015
@mogsdad
Silenced logging for Issue #9
48106a9 
Just commented out for now.
@mogsdad
Copy link
Collaborator Author

mogsdad commented Oct 8, 2015

Fix available in this version on my branch.

@mogsdad
Copy link
Collaborator Author

mogsdad commented Oct 9, 2015

Merged to main.

@mogsdad mogsdad closed this as completed Oct 9, 2015
@mogsdad
Copy link
Collaborator Author

mogsdad commented Oct 14, 2015

It's back! Fix was merged out by f04ae3b#diff-d2d08e4fa6134f3ba409bec1ddd3e970

@mogsdad mogsdad reopened this Oct 14, 2015
mogsdad added a commit that referenced this issue Oct 14, 2015
@mogsdad
Re-fixed Issue #8 and Issue #9
87235be 
Changes for these issues had been removed by a bad merge.
@mogsdad mogsdad closed this as completed Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mogsdad mogsdad

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mogsdad