fix: vendor OpenSSL for aarch64 release builds#72
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The release workflow cross-compiles
aarch64-unknown-linux-gnufrom Ubuntu x86_64.openssl-syswas trying to discover a target OpenSSL install and failed with:Could not find directory of OpenSSL installation.Validation
cargo tree -p tinycloud-node -e features --target aarch64-unknown-linux-gnuconfirmsnative-tls/openssl/openssl-sysvendored features are enabled for aarch64 Linuxcargo tree -p tinycloud-node -e featuresconfirms vendored OpenSSL is not enabled for the host targetcargo check -p tinycloud-nodegit diff --checkNote
Existing failed tag workflows may need a new tag or retag after this merges, because GitHub tag workflows use the workflow file from the tagged commit.