Skip to content

Conversation

@shaneahmed
Copy link
Member

  • 🚨 Use logger instead of print in slide_info.py.
  • 🔥 Remove slide-info.py from wsicore
  • 🎨 Update cli/slide_info to use wsi.slide_info instead of slide_info.py

- 🚨 Use logger instead of print in `slide_info.py`.
- 🔥 Remove slide-info.py from wsicore
- 🎨 Update cli/slide_info to use wsi.slide_info instead of slide_info.py
@shaneahmed shaneahmed self-assigned this Mar 10, 2023
@shaneahmed shaneahmed added the refactoring Code Refactoring label Mar 10, 2023
@shaneahmed shaneahmed requested a review from adamshephard March 10, 2023 15:48
@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #562 (5291857) into develop (a2930e9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #562      +/-   ##
===========================================
- Coverage    99.51%   99.51%   -0.01%     
===========================================
  Files           63       62       -1     
  Lines         6591     6588       -3     
  Branches      1077     1077              
===========================================
- Hits          6559     6556       -3     
  Misses          20       20              
  Partials        12       12              
Impacted Files Coverage Δ
tiatoolbox/cli/slide_info.py 100.00% <100.00%> (ø)
tiatoolbox/wsicore/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaneahmed shaneahmed merged commit bf5f7c6 into develop Mar 13, 2023
@shaneahmed shaneahmed deleted the dev-use-logger-for-slide-info branch March 13, 2023 10:56
@shaneahmed shaneahmed added this to the Release v1.4.0 milestone Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactoring Code Refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants