Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Big List of Small Issues #53

Closed
Tmplt opened this issue May 11, 2018 · 5 comments

Comments

@Tmplt
Copy link
Owner

commented May 11, 2018

For v0.5.0, this issue shall contain lists of smaller issues that are not big enough to warrant its own ticket. All of these issues should be fixed before next major/minor release.

  • libgen.py: titles are recorded with an added space at the end, which makes written files have an extra space in it;
  • when writing files with unset year, (-1) is in the filename, instead of being omitted;
  • if a plugin is found, but any of its imports fail, bookwyrm just complains that it couldn't find any plugins;
    • flush plugin handler logs to std[out,cerr];
    • respect [--debug] and prefix the message with the log level, alá the log screen;
  • the --year option is ignored;
  • it's not clear if there are still plugins running in the background (some plugin status should be added to the footer);
    • improve message, state end of search when no plugins are running;
    • plugin counter may be non-zero when it shouldn't be; the backend should update the frontend when a plugin terminates;
  • fuzzy matches in bool item::matches() are currently hard-coded for >75% — a cli option should probably be added to set the accuracy (how matching work should probably be explained somewhere too);
    • make core::plugin_handler take plugin paths and fuzzy threshold via options struct;
    • add --accuracy option;
  • libgen.py doesn't seem to work, investigate;

and more to come...

@Tmplt Tmplt added the enhancement label May 11, 2018

@Tmplt

This comment has been minimized.

Copy link
Owner Author

commented May 11, 2018

@CuriouslyCurious

This comment has been minimized.

Copy link
Contributor

commented May 11, 2018

I'll start bug-testing tomorrow. ;)

@Tmplt Tmplt added this to the v0.6.0 milestone May 11, 2018

Tmplt added a commit that referenced this issue May 12, 2018
core: flush plugin handler log buffer upon destruction
Before this, logs made by the plugin handler (e.g. when loading a
plugin and possible failing) were lost if the TUI didn't start.

Related to #56, #53
Tmplt added a commit that referenced this issue May 12, 2018
Tmplt added a commit that referenced this issue May 12, 2018
Tmplt added a commit that referenced this issue May 12, 2018
Tmplt added a commit that referenced this issue May 12, 2018
Tmplt added a commit that referenced this issue May 21, 2018
Tmplt added a commit that referenced this issue May 21, 2018
Tmplt added a commit that referenced this issue May 21, 2018
core: match against year modifier
the --year option is now adhered to

Related to #53
@Tmplt

This comment has been minimized.

Copy link
Owner Author

commented May 21, 2018

As for the some times rogue space in the tail of the title from libgen.py, prefixed and suffixed whitespace should probably be cleared when creating the actual item. This can be done in each component's get_value().

Tmplt added a commit that referenced this issue May 22, 2018
Tmplt added a commit that referenced this issue May 22, 2018
display how many plugins are still running
Related to #53

A quick-and-dirty implementation. In the future, it might be better to
have a two-way communication between the front and backend, instead of
constructing the TUI with a vanity argument.

The backend does not update the frontend upon the termination of a
plugin; the user must manually update the TUI for the plugin counter to
reach zero.
Tmplt added a commit that referenced this issue May 23, 2018
Tmplt added a commit that referenced this issue May 23, 2018
@Tmplt

This comment has been minimized.

Copy link
Owner Author

commented May 27, 2018

As for libgen.py not working: a quick python3 libgen.py gives us

Traceback (most recent call last):
  File "libgen.py", line 492, in <module>
    LibgenSeeker(item).search()
  File "libgen.py", line 192, in search
    self.process_libgen(table)
  File "libgen.py", line 394, in process_libgen
    self.feed(make_item(row))
  File "libgen.py", line 387, in make_item
    misc = bw.misc_t(extract_mirrors(), extract_isbns() or [])
  File "libgen.py", line 349, in extract_mirrors
    libgenpw, libgenio, bookfi, bok = mirrors
ValueError: too many values to unpack (expected 4)

Looks like libgen changed their HTML... again.

Tmplt added a commit that referenced this issue May 28, 2018
@Tmplt

This comment has been minimized.

Copy link
Owner Author

commented Dec 16, 2018

Closing this because it lacks the structure multiple separate issues would have.

@Tmplt Tmplt closed this Dec 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.