Skip to content

Conversation

@crericha
Copy link
Contributor

@crericha crericha commented Feb 8, 2023

No description provided.

@crericha crericha requested review from eakmanrq and tobymao February 8, 2023 01:41
Copy link
Contributor

@eakmanrq eakmanrq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to this. It seems like this is the will be the biggest thing that people will have to think about when migrating.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to more explicitly call out that they can still manage their docs we just don't have SQLMesh commands yet to do that. I saw that since the bullet below more explicitly calls this out and so it might make sense to do the same here.

@eakmanrq eakmanrq added the Documentation Improvements or additions to documentation label Feb 8, 2023
@tobymao
Copy link
Contributor

tobymao commented Feb 9, 2023

@crericha ready for merge?

@crericha crericha merged commit d8e3e41 into main Feb 15, 2023
@crericha crericha deleted the dbt-documentation branch February 15, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants