Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geometries unhashable #320

Merged
merged 1 commit into from Sep 11, 2015
Merged

Make geometries unhashable #320

merged 1 commit into from Sep 11, 2015

Conversation

@sgillies
Copy link
Member

@sgillies sgillies commented Sep 6, 2015

Shapely's geometries are mutable, but we're providing a hash function. These two features are inconsistent. Rather than remove mutability (for now) we'll remove the hashability.

See #209

Shapely's geometries are mutable, but we're providing a hash function.
These two features are inconsistent. Rather than remove mutability
(for now) we'll remove the hashability.

See #209
@sgillies sgillies added the bug label Sep 6, 2015
@sgillies sgillies added this to the 1.6 milestone Sep 6, 2015
@sgillies sgillies removed this from the 1.6 milestone Sep 6, 2015
@sgillies
Copy link
Member Author

@sgillies sgillies commented Sep 6, 2015

@jwass I'm revisiting the change I made in #211, which seems wrong. I'd love your assessment on the effects of this PR on GeoPandas et al.

Not this weekend, of course. I'm putting my computer away until Tuesday in about 30 mins :)

@jwass
Copy link
Collaborator

@jwass jwass commented Sep 8, 2015

Will do.

@jwass
Copy link
Collaborator

@jwass jwass commented Sep 9, 2015

@sgillies See geopandas/geopandas#221.

As far as GeoPandas goes, I think this only affects anyone that has a merge/join that includes the geometry column in the list of fields to join. My guess is it's rare to have done so intentionally but I proposed additional functionality that would explicitly support that operation, so they won't be left out in the cold.

Once geopandas/geopandas#222 is merged, then the GeoPandas tests will pass against this change.

sgillies added a commit that referenced this issue Sep 11, 2015
@sgillies sgillies merged commit 5cde6d2 into maint-1.5 Sep 11, 2015
2 checks passed
@sgillies sgillies deleted the unhashable branch Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants