Skip to content

Conversation

@Zabuzard
Copy link
Member

just a test

@Zabuzard Zabuzard requested review from a team as code owners January 11, 2023 15:37
@Zabuzard Zabuzard force-pushed the test branch 9 times, most recently from 142f41b to 03d8af8 Compare January 11, 2023 16:41
@marko-radosavljevic
Copy link
Contributor

marko-radosavljevic commented Jan 13, 2023

Fixed languagetool not finding typos. ^^

It's unclear how well it will behave on real world use-cases, this setup is very experimental so I will play with it more.

Some of the potential issues I noticed:

  • We have limitations on the api and checking power: https://dev.languagetool.org/public-http-api
    • And it doesn't help that this langaugetool action scans every single file, instead only files that have been modified.
  • Action is 'In progress' for 20mins already, unsure if it's broken.
  • Not sure how well it will work on the code and markdown, although all checks that would trigger on code syntax are disabled, like underscores and similar.

@marko-radosavljevic
Copy link
Contributor

Action is erroring out with 'Only 65535 characters are allowed; 97549 were supplied. []', because the request is too large for github's liking.

I believe changing reporter to github-pr-review might solve this problem.

I think review comments are much better anyway, because we can discuss if it's a real mistake or something that should be ignored. If it could suggest fixes that you can merge from the UI, it would be a really nice experience.
Also, with review comments, you can 'resolve' them to hide them from the review UI, so it's not cluttering everything.

Currently, it looks like this:
image

### No

sdsd
* dasd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: dad, dash, ASD, deism, DSD, dads, deist, DPSD, FASD
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

sdsd
* dasd

* ddd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: DDD, Did, DVD, Add, Odd, Dad, DDR, DDT, ADD, DDS, HDD, Dud, DDA, DDB, DDC, DDE, DMD, DND, DPD, DSD, TDD, DCD, Dds, BDD, CDD, D2D, DBD, DD, DDH, DDI, DDL, DDM, DDO, DDV, DGD, DID, DOD, DUD, DZD, EDD, GDD, LDD, MDD, ODD, PDD, QDD, SDD, VDD, Dd, Dded, D dd, D&D, DTD, DnD, DoD, Dodd, And, Had, Day, Due, End, Died, Do, Led, Old, Added, Mid, Red, CD, Dr, God, Aid, Bad, Dead, Die, Dog, Dry, Ad, Bed, Bid, Duo, Fed, CDs, Dan, GDP, HD, Ltd, PhD, Adds, Ads, Mud, Odds, Rod, DVDs, Del, FDP, ID, IDF, LCD, LED, SD, Ted, Todd, Dam, Deed, Den, Dig, Dot, Dub, Dug, Dye, Hid, Id, Kid, Lid, Mad, Mod, Pad, Pod, Rid, Sad, ADC, ADP, BSD, Bud, CCD, CDC, CDU, DA, DEC, DL, DM, DNS, DRM, DSM, DSO, DSP, DT, Dec, Dee, GDR, JD, LSD, NAD, PD, PDF, PDP, UDP, Cod, dB, Dim, Din, Dip, Dyed, Eds, Nod, Wed, ADR, ASD, Ada, CDA, CDR, DAC, DAT, DCC, DCI, DG, DLR, DMC, DMS, DMZ, DRC, DSC, DSL, DSS, DST, DTM, DTS, DUI, DUP, Dada, Doe, Dow, Eddy, FD, FDR, HUD, IDs, Judd, Kidd, LD, MDC, MDR, PDA, PDS, PPD, PSD, RCD, RDS, SDA, SDK, TDI, UDF, WMD, Dew, Fad, Lad, Med, Ode, Sod, AD, ADT, APD, BCD, BDS, BMD, BPD, CDO, CDT, CFD, CKD, CND, CSD, DBA, DCE, DCL, DCM, DKK, DLA, DLL, DME, DMG, DMK, DNR, DOA, DPI, DRG, DRI, DSA, DSB, DSE, DTC, DTI, DVR, DWM, Dido, Dir, ESD, Edda, FDI, FWD, GDF, GDI, GED, HDB, HDR, HDV, IDC, IED, JDM, Jed, LDA, MCD, MDI, MDS, MHD, MVD, NPD, PDT, QED, RDA, RDC, RFD, SBD, SDI, SDR, SVD, TLD, Tod, UDC, UDR, WD, Daddy, Deg, Doc, Dodo, Dude, ACD, Adm, CDN, CVD, DCB, DCF, DLM, DMP, DMV, DOB, DPT, DSR, DTA, DTP, DWI, DWT, EDP, FDC, GDS, GMD, HND, IDG, IDL, IUD, JDL, LDC, MDF, MDL, MDM, MDP, MDT, MDX, NDB, PGD, SDC, SDM, Dado, Dads, Dz, Rad, CDV, DBC, DLI, DPN, DPs, DRV, DVP, DVS, DWG, FDDI, HDS, MLD, PDQ, SGD, VDU, Adj, Ado, Cad, Cud, Dab, Duds, Duh, Hod, Tad, TBD, VDT, Adv, Bod, ETD, Ind, ODs, YTD, CDP, DJ, DNA, MD, Ned, TD, Dbl, Dob, Doz, Dpt, Cpd, 1D, 2D, 2nd, 3D, 3DO, 3rd, 4D, 8D, AAD, ABD, ADA, ADB, ADDX, ADF, ADG, ADH, ADJ, ADK, ADL, ADM, ADMD, ADN, ADQ, ADS, ADV, ADX, ADY, ADZ, AED, AFD, AGD, AHD, AID, AKD, ALD, AMD, AND, AOD, ARD, ATD, AUD, AWD, AXD, AYD, AZD, BBD, BD, BDA, BDB, BDC, BDE, BDF, BDG, BDH, BDI, BDJ, BDK, BDL, BDM, BDN, BDO, BDP, BDQ, BDR, BDT, BDU, BDV, BDW, BDX, BDY, BDZ, BED, BFD, BGD, BHD, BID, BKD, BLD, BND, BOD, BRD, BUD, BVD, BWD, BXD, BZD, CAD, CADD, CBD, CDB, CDDB, CDDL, CDDP, CDE, CDF, CDG, CDH, CDI, CDJ, CDK, CDL, CDM, CDS, CDW, CDZ, CED, CGDD, CHD, CID, CLD, CMD, COD, CPD, CRD, CUD, Cd, Cid, D, D10, D11, D12, D13, D14, D15, D16, D17, D18, D19, D20, D21, D22, D23, D24, D25, D26, D27, D28, D29, D30, D31, D32, D33, D34, D35, D36, D37, D38, D39, D40, D41, D42, D45, D46, D48, D50, D51, D52, D55, D56, D57, D58, D59, D60, D61, D62, D63, D64, D65, D66, D67, D68, D70, D71, D72, D73, D74, D76, D78, D79, D8, D80, D82, D83, D86, D89, D90, D91, D96, D97, D99, DAA, DAB, DAE, DAF, DAI, DAJ, DAK, DAL, DAR, DAU, DAV, DAX, DB7, DB9, DBB, DBF, DBL, DBO, DBP, DBQ, DBR, DBU, DBZ, DC, DCA, DCK, DCN, DCO, DCP, DCR, DCS, DCT, DCU, DDAF, DDEA, DDHC, DDSP, DDTs, DDWG, DE, DEA, DEB, DEG, DEI, DEL, DEM, DEP, DEQ, DES, DET, DEU, DFA, DFB, DFE, DFF, DFG, DFI, DFL, DFM, DFN, DFO, DFP, DFS, DFT, DFW, DGA, DGDDI, DGE, DGF, DGH, DGI, DGS, DGT, DH, DHA, DHC, DHH, DHI, DHM, DHP, DHR, DHS, DHT, DI, DIC, DIF, DIL, DIN, DIP, DIR, DIV, DIY, DJF, DJG, DJI, DJO, DJT, DJU, DK, DKB, DKP, DKR, DKZ, DLC, DLF, DLG, DLH, DLP, DLT, DMF, DMI, DMM, DMO, DMR, DN, DNB, DNF, DNK, DNL, DNT, DO, DOC, DOE, DOF, DOI, DOJ, DOM, DON, DOP, DOS, DOT, DP, DPA, DPB, DPC, DPE, DPH, DPO, DPS, DPSD, DPU, DPW, DR, DR1, DRH, DRP, DRS, DRT, DS, DSF, DSG, DSI, DSK, DSN, DSQ, DSU, DSV, DTQD, DTU, DTV, DTW, DUS, DVA, DVB, DVI, DWH, DWV, DXB, DXF, DXM, DXO, DZA, DZI, DZO, Dem, Di, Dis, Dix, Don, Du, Dy, EAD, EDA, EDC, EDF, EDI, EDL, EDM, EDS, EDT, EDW, EDX, EED, EGD, EID, ELD, EMD, END, ERD, Ed, FCD, FDA, FDB, FDF, FDM, FDS, FED, FFD, FID, FJD, FOD, FPD, FRD, FSD, FUD, GAD, GDB, GDC, GDE, GDM, GDN, GDT, GND, GRD, GYD, Gd, HDDS, HDE, HDF, HDI, HDL, HDM, HDO, HKD, HMD, HPD, IAD, ICD, ID3, IDE, IDH, IDK, IDM, IDN, IDR, IDS, IDT, IFD, IMD, IPD, IRD, ISD, IVD, Ida, JDE, JDG, JDK, JDN, JED, JLD, JMD, JWD, KDG, KDP, KDS, KED, KOD, KPD, KTD, KWD, LBD, LDE, LDH, LDK, LDL, LDT, LDW, LLD, LMD, LND, LPD, LRD, LTD, LVD, LYD, MAD, MDA, MDB, MDE, MDG, MDJ, MDK, MDN, MDQ, MDRD, MDV, MED, MGD, MID, MKD, MPD, MSD, MTD, Md, ND, NDDL, NDF, NDH, NDK, NDR, NDS, NDT, NED, NID, NLD, NTD, NZD, Nd, OAD, OCD, OD, ODB, ODC, ODF, ODG, ODI, ODM, ODN, ODP, ODR, ODS, OED, OGD, OND, ORD, OSD, PADD, PCD, PDB, PDC, PDG, PDI, PDJ, PDK, PDL, PDO, PDU, PDX, PED, PFD, PHD, PID, PKD, PLD, PND, PRD, PVD, Pd, QDR, RAD, RBD, RD, RDB, RDF, RDI, RDJ, RDM, RDP, RDT, RED, RHD, RJD, RKD, RLD, RPD, RTD, RUD, RWD, Rd, SAD, SCD, SDF, SDH, SDJ, SDN, SDO, SDP, SDU, SDV, SHD, SID, SND, SOD, SRD, STD, SUD, SYD, Sid, TAD, TCD, TDA, TDC, TDE, TDF, TDG, TDM, TDP, TDR, TDS, TDT, TED, TGD, THD, TID, TKD, TMD, TND, TSD, TTD, TWD, UAD, UCD, UDB, UDDM, UDL, UDM, UDS, UED, UFD, UMD, UND, UPD, URD, USD, VD, VDA, VDB, VDC, VDI, VDM, VDN, VDX, VGD, VHD, VND, VRD, VSD, WAD, WDC, WDI, WDM, WDS, WSD, X2D, XCD, YHD, ZAD, ZDJ, ZED, Dag, Db, Deb, Def, Didn, Div, Dos, Dpi, Duded, Dun, Fwd, Gad, Ids, Pud, Std, Wad, Yd, Yid, Zed, A&D, ADHD, ADI, ADU, BYD, DAP, DAW, DB, DBS, DDLC, DDoS, DEX, DFC, DFV, DGP, DHL, DJed, DJs, DKA, DLK, DLS, DM'd, DMA, DMX, DMed, DMs, DNC, DNI, DNP, DOH, DOL, DQ, DRA, DTT, DV, DVC, DVM, DVT, DW, DX, Didi, DoJ, DoS, ECD, EDB, EDU, EOD, FHD, FMD, GID, GTD, HDDs, HRD, HWD, IBD, IDB, IDP, IDQ, IDed, IND, JDA, JVD, KD, KDE, L&D, LDF, LDS, LOD, MDs, NCD, NDA, NDC, NDP, NHD, NWD, ODT, PMD, R&D, Rodd, Rudd, SDE, SDG, SDL, SDS, SPD, SSD, Syd, UHD, UID, Udo, VVD, VoD, XD, XSD, ZD, ZDs, Cmd, dBm, Dep, Dev, Dm, Dm'd, Dmed, Dms, Dox, Gtd, Vid
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jesus, it doesn't work nicely with random characters. 😄

and I don't think there is any easy way to limit the amount of suggestions api returns

* dasd

* ddd
dasdasd

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: dastard
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

# Chained Comparisons

When writing an expression in math to say something along the lines of
Whn wriding a esxpression in maff to sai someting aloong, The, lihnes, of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: SAI, said, San, saw, say, sat, Sam, sail, ski, SAS, sad, SAM, SAP, sac, sap, sax, sci, SGI, CAI, SAA, SBI, SDI, Sat, sag, sari, SMI, Saki, AAI, AI, DAI, EAI, FAI, HAI, IAI, JAI, Mai, OAI, RAI, SA, SA2, SAB, SAC, SAD, SAE, SAF, SAG, SAH, SAIC, SAJ, SAK, SAN, SAO, SAQ, SAR, SAT, SAU, SAV, SAW, SAX, SAY, SAZ, SCI, SFI, SI, SII, SKI, SLI, SNI, SOI, SPI, SRI, SSI, STI, SVI, Sal, Shi, Si, Sui, TAI, UAI, Kai, Sami, Sri, São, Tai, Tsai, ai, tai, die, lie, tie, pie, vie, fie, Lie, hie, a, was, I, as, at, an, had, has, can, she, day, may, same, set, so, air, died, law, main, man, see, six, son, wait, way, St, car, far, gas, lies, pay, ran, says, sea, seat, star, via, view, war, Sir, aid, am, bad, bar, fan, gain, hair, hey, key, laid, lay, map, paid, pair, rail, safe, sale, save, semi, ship, skin, soil, stay, sub, suit, tail, tax, tied, van, Asia, FBI, PA, Spain, ad, ask, ban, bay, cap, cat, dies, diet, eat, fair, gap, hat, heir, jail, lap, mail, pain, raid, rain, raw, ray, salt, sand, sang, seal, siege, sit, sky, soap, span, spin, sum, sun, tag, ties, Dan, Jay, LA, MA, Mac, Max, Nazi, Ray, ash, bag, bat, ear, fail, fat, jaw, keys, lab, oak, pan, rap, saint, sake, sank, seas, seize, slip, spy, swim, taxi, tier, vein, Han, Kiev, Mar, Neil, PCI, Pat, RAM, Reid, SD, SF, SG, SK, SL, SQL, SSR, SVP, Saudi, Sean, Shaw, Stan, Thai, USA, USAF, Wei, bail, cab, dad, dam, gag, hail, hay, lieu, mad, maid, nail, pad, par, pier, ram, rat, sack, saga, sage, sails, scan, shy, sic, slab, slain, slam, snail, snap, spa, sue, swap, tan, tap, vain, wax, AF, BSA, CAA, CGI, CPI, CSA, CSI, Cain, DA, ESA, GI, GUI, Ham, Hay, Jain, Kay, Lao, MRI, Mae, Mali, Mao, Meiji, NAD, NSA, PAC, PRI, PSA, RSA, SBS, SCSI, SLR, SMS, SNL, SNP, SOS, SUV, Sand, Sara, Seine, Sgt, Sinai, Sol, Sue, Sufi, UA, Wii, bait, cam, fax, fief, gait, ham, hi, jar, lag, lair, lied, ma, mat, max, pa, pas, pi, pies, psi, sans, scam, scar, seam, sec, ska, skip, skis, skit, slid, slim, slit, soy, spam, spar, spit, stab, stain, stir, swam, swan, sway, ta, tab, tar, var, veil, AAU, AIF, AIG, Bali, CAC, CBI, CCI, DAC, DAT, DCI, DUI, FAO, FAQ, FSA, Fay, Gaia, Heidi, Hui, IAS, IAU, ISAF, JSA, Kali, Kiel, Mani, Mari, Maui, Meir, Mia, NAC, Nair, Nam, Nat, OAS, OSI, PKI, PPI, Pa, Pam, RAC, SARS, SBC, SCC, SDA, SDK, SFR, SLA, SLC, SOE, SPL, SRAM, SRC, SSA, SSE, SSL, SSP, SST, SWAT, Saab, Sang, Saul, TAC, TDI, TSA, Tao, UAW, UPI, VAX, WAC, WWI, ah, cal, fad, gal, lad, lax, lien, maxi, moi, oar, pal, paw, rag, rein, sacs, sane, sash, satin, saws, seq, sh, shah, sham, shin, sieve, sir, skid, slag, slap, slay, sly, sod, sow, spas, spat, st, stag, stair, stat, syn, tau, vat, vied, yam, yaw, AAT, AD, AIT, ASAP, CLI, CTI, Cali, DPI, DRI, DSA, DTI, Diem, EAM, FAC, FCI, FDI, FSI, GDI, IAA, IAC, IAP, JAL, Jan, Kari, LSA, LSI, Lat, Leif, MDI, MSI, Magi, Meier, PMI, RMI, RPI, RSI, Riel, SACD, SALT, SBA, SBB, SBD, SBT, SCS, SDR, SFC, SFIO, SFO, SFU, SFX, SGA, SGC, SLP, SLS, SME, SMG, SNA, SNC, SOP, SPF, SRA, SRM, SRS, SRT, SSM, SSW, STP, SVD, SVR, Saar, Sabin, Sade, Sadie, Sakai, Sec, Slav, TBI, Tia, WAP, asp, av, ax, dais, hag, jab, lac, lat, mag, mar, nap, nay, oat, pat, phi, pied, sago, saris, seine, sew, sf, shad, shan, sip, skim, snag, soak, soar, staid, sup, swami, tam, tat, wadi, wan, yak, BRI, BWI, CFI, CNI, DWI, Dali, Esau, FAM, GAF, GAM, HMI, HSA, IAB, IPI, Jami, NAL, RCI, SBR, SCU, SDC, SDM, SGM, SGP, SLT, SMF, SNF, SRO, SSO, SVC, Sana, Scan, Seiko, Shari, Spam, Span, UAR, Uzi, WAIS, aim, beys, bier, gar, jag, jay, magi, maim, nag, obi, pail, pap, rad, rah, sahib, saith, scab, sear, slat, sqq, swab, val, wag, wail, DLI, FYI, Fri, GMI, HRI, Kasai, Masai, OAP, SGD, SHF, SKU, SLN, SOB, Salk, Swazi, Tami, UAM, VRI, ain, bah, bani, cad, dab, fay, gab, leis, maw, mien, nab, nae, oaf, pah, sags, saps, sass, sate, scad, sch, shim, shiv, sis, slaw, snip, sob, soc, sop, sou, spay, ssh, sty, swag, swat, tad, vies, waif, zap, Gail, MLI, SASE, SSAS, Staci, ail, baa, caw, fain, hap, mam, naif, shay, sot, swain, swig, vac, tali, yap, AAA, Ali, RAF, RBI, SOs, SWAK, jam, sin, weir, gay, A, AA, AAB, AAC, AAD, AAE, AAF, AAG, AAH, AAIB, AAJ, AAK, AAL, AAM, AAN, AAO, AAP, AAQ, AAR, AAS, AAV, AAW, AAX, AAY, AAZ, AB, AC, ACI, AE, AEI, AFI, AG, AGI, AHI, AIB, AIC, AID, AIE, AIH, AII, AIJ, AIK, AIM, AIO, AIP, AIQ, AIS, AIU, AIV, AIW, AIY, AIZ, AIs, AJ, AJI, AK, AL, AM, AN, ANI, AO, AOI, AP, API, AQI, AR, ARI, ASA, ASFI, ASPI, AT, ATI, AU, AUI, AV, AVI, AX, AYI, AZ, AZI, Ac, Ag, Al, Am, Ar, As, At, Au, Av, BA, BAA, BAE, BAF, BAH, BAII, BAM, BAP, BAS, BAU, BAV, BAW, BAX, BAZ, BBI, BCI, BDI, BEI, BFI, BGI, BHI, BII, BJI, BKI, BLI, BMI, BNI, BOI, BPI, BSI, BTI, BUI, BVI, BYI, Ba, Bi, CA, CAB, CAD, CAF, CAG, CAH, CAJ, CAK, CAL, CAM, CAN, CAP, CAQ, CAT, CAU, CAV, CAW, CAY, CDI, CEI, CHI, CI, CII, CMI, COI, CQI, CSAE, CSAIO, CSAR, CVI, Ca, Cal, Can, Chi, Ci, DAA, DAB, DAE, DAF, DAJ, DAK, DAL, DAPI, DAR, DAU, DAV, DAX, DDI, DEI, DFI, DGI, DHI, DI, DJI, DMI, DOI, DSI, DVI, DZI, Day, Di, EAA, EAC, EAD, EAE, EAH, EAK, EAL, EAN, EAO, EAP, EAS, EAT, EAU, EAV, EAX, EAY, EBI, EDI, EFI, EI, ELI, EMI, ENI, ENSAI, EPI, ESAA, ESAD, ESI, Eli, FA, FAA, FAB, FAE, FAF, FAG, FAH, FAK, FAP, FAT, FAX, FAZ, FEI, FFI, FGI, FI, FII, FJI, FMI, FTI, FWI, GA, GA3, GAA, GAB, GAC, GAD, GAE, GAFI, GAG, GAIN, GAL, GAO, GAP, GAR, GAS, GAV, GCI, GEI, GFI, GHI, GOI, GRI, GSA, GSI, GTI, Ga, Gap, Gay, HA, HAC, HAE, HAP, HCI, HDI, HI, HKI, HOI, Ha, Hal, Haw, IA, IA4, IA8, IAD, IAE, IAF, IAG, IAH, IAN, IAO, IASI, IAV, ICI, IFI, IGI, IOI, IRI, ISA, ISAM, ISAS, ISI, IVI, Ia, Ian, JA, JAA, JAC, JAF, JAG, JAK, JAP, JNI, JRI, Jap, KAL, KAV, KAZ, KOI, KSA, Kan, Key, LAH, LAK, LAN, LAR, LAT, LAU, LAW, LAZ, LBI, LFI, LHI, LI, LNI, LOI, LPI, LRI, LSAT, LTI, La, Lab, Las, Li, M3I, MAD, MAF, MAG, MAH, MAIF, MAJ, MAK, MAL, MAM, MAP, MAPI, MAR, MAS, MAT, MAV, MBI, MCI, MFI, MGI, MI, MMI, MOI, MPI, MS2I, MSA, MSSI, Maj, Man, May, NAB, NAF, NAG, NAH, NAM, NAO, NAP, NAS, NAU, NI, NMI, NNI, NOI, NPAI, NPI, NUI, Na, Nan, Ni, OAB, OACI, OAD, OAE, OAL, OAM, OAO, OAR, OAT, OCI, ODI, OHI, OMI, OPI, ORI, OSA, OUI, PAB, PAE, PAF, PAG, PAH, PAIO, PAJ, PAK, PAL, PAM, PAN, PAO, PAP, PAQ, PAR, PAS, PBI, PDI, PEI, PGI, PHI, PISAI, PNI, POI, PTI, PVI, PWI, PXI, Pan, Pei, QA, QAG, QAT, QI, RAA, RAB, RAD, RAE, RAG, RAID, RAJ, RAP, RAR, RAS, RAW, RAY, RDI, REI, RFI, RI, RLI, ROI, RRI, RSAC, RVI, Ra, Rae, S, S10, S11, S12, S13, S14, S15, S16, S17, S18, S19, S20, S21, S22, S23, S24, S25, S26, S27, S28, S29, S30, S31, S33, S34, S35, S36, S37, S3A, S3IC, S40, S41, S42, S44, S45, S46, S47, S50, S51, S52, S53, S60, S61, S63, S75, S80, S85, S90, S99, SAAB, SAAF, SAAQ, SADC, SADT, SAIME, SALS, SAMU, SARA, SARL, SART, SATA, SATB, SAVS, SB, SBF, SBG, SBK, SBM, SBV, SC, SC2, SCA, SCAC, SCAM, SCB, SCD, SCIM, SCJ, SCL, SCM, SCN, SCO, SCP, SCPI, SCR, SCV, SDD, SDEI, SDF, SDH, SDIO, SDIS, SDJ, SDN, SDO, SDP, SDSI, SDU, SDV, SE, SEA, SEAC, SEAL, SEAS, SEAT, SEB, SEC, SEF, SEG, SEJ, SEK, SEL, SEM, SEO, SEP, SER, SES, SET, SEU, SEV, SEX, SEY, SEZ, SFAP, SFE, SFF, SFG, SFH, SFP, SFS, SFT, SFW, SG3, SGAM, SGB, SGE, SGF, SGG, SGH, SGK, SGL, SGN, SGR, SGS, SGT, SGU, SGX, SH, SHA, SHD, SHG, SHK, SHM, SHN, SHP, SHR, SHU, SIA, SIAC, SIAD, SIB, SIC, SID, SIG, SIL, SIM, SIN, SIP, SIS, SIT, SIV, SJ, SJA, SJM, SJP, SJR, SJW, SKA, SKIP, SKK, SKN, SKZ, SLAR, SLB, SLF, SLG, SLIM, SLL, SLO, SLQ, SLSI, SLV, SLZ, SM, SMA, SMAC, SMB, SMC, SMH, SMIC, SMIG, SMK, SML, SMM, SMMI, SMN, SMR, SMT, SN, SNB, SND, SNE, SNG, SNIM, SNR, SNS, SNU, SNV, SO, SOA, SOAD, SOAP, SOC, SOD, SON, SOX, SP, SP1, SPA, SPAD, SPAN, SPB, SPC, SPE, SPG, SPH, SPM, SPP, SPR, SPS, SPT, SPV, SPW, SQP, SQR, SR1, SR2, SR3, SRB, SRD, SRE, SRF, SRP, SRU, SRV, SRX, SS, SS7, SSAP, SSB, SSF, SSG, SSH, SSII, SSIM, SSK, SSPI, SSS, SSV, ST, STA, STAE, STAR, STAV, STB, STC, STD, STE, STF, STG, STID, STIF, STL, STM, STN, STO, STR, STS, STT, STV, STX, SU, SUA, SUD, SUK, SUR, SUS, SVA, SVB, SVE, SVG, SVK, SVL, SVM, SVN, SVT, SW, SWAG, SWE, SWL, SWR, SWT, SWV, SWZ, SXB, SXM, SY, SYC, SYD, SYL, SYN, SYR, SYT, SYX, SZ, SZL, Sabik, Sadr, Saiph, Saks, Sask, Sb, Sc, Se, Sen, Sep, Set, Shah, Siam, Sid, Siri, Sm, Sn, Soc, Son, Sp, Sq, Sr, Sta, Ste, Stu, Sun, TA, TAA, TAD, TAE, TAF, TAG, TAH, TAJ, TAM, TAN, TAO, TAP, TAPI, TAT, TCI, TEI, TGI, TI, TMI, TPI, TRI, TSAF, TSI, TTI, Ta, Tad, Ti, UAA, UAB, UAC, UAD, UAE, UAG, UAH, UAL, UAP, UAS, UAU, UFI, UGI, UI, UMI, UNI, URI, USAM, USI, VA, VAB, VAC, VAE, VAM, VAP, VAT, VCI, VDI, VEI, VFI, VI, VMI, VPI, VSAB, VSAV, VSTI, Va, Val, Van, WA, WAB, WAD, WAG, WAM, WDI, WI, WRI, WSA, Wac, XAF, XAP, XAU, Xi, YAC, YAG, YAR, ZA, ZAC, ZAD, ZAE, ZAF, ZAM, ZAP, ZAR, ZAZ, ZI, ZTI, aah, ab, ac, asap, ass, aw, bap, bey, bi, ca, cay, chi, dag, dpi, ea, fa, fab, fag, fey, gad, ha, haj, haw, hied, hies, i, ii, iii, la, lain, lam, lav, lei, lief, lii, lvi, lxi, mac, mas, mi, nah, oi, poi, s, sarin, scag, scat, sen, sex, shag, shh, sim, snit, sol, spic, spiv, sq, std, swiz, ti, uni, vi, vii, wad, wain, xci, xi, xii, xvi, xxi, ya, ABI, ADI, AIX, AMI, Abi, BAC, Bain, Biel, CAE, CAS, CSAM, CSAT, CZI, DAP, DAW, DNI, DSAT, Dalí, Dani, EOI, ESXi, Esri, FAS, FSSAI, GA4, GNI, IAM, IAT, INI, JCI, Jair, KPI, Kat, Kia, Leia, MAE, MAU, MFi, MSCI, MYI, NAK, NCI, NRI, NSAID, NTI, OA, OAN, OSAP, PAA, PAs, PSAT, Pia, RKI, RSSI, RTI, Raj, Ravi, Rey, S&P, S&W, SABIS, SAML, SATs, SCID, SDE, SDG, SDL, SDS, SFA, SFM, SHS, SHT, SJO, SLAs, SMP, SMU, SPAC, SPD, SQS, SSC, SSD, SSID, SSN, SSRI, STIs, STW, SV, SaaS, Saami, Sadiq, Sajid, Samir, Saúl, Seán, Shia, SoC, Syd, TUI, UAT, UAV, UCI, USAID, UTI, WAV, WSGI, Xavi, Xia, Yi, ais, açai, bam, chai, fav, hah, hào, mAh, mCi, nav, naïf, padi, pax, reiki, saké, sawn, shat, src, tsar, yay, Şahin
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

# Chained Comparisons

When writing an expression in math to say something along the lines of
Whn wriding a esxpression in maff to sai someting aloong, The, lihnes, of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: something, so meting
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

# Chained Comparisons

When writing an expression in math to say something along the lines of
Whn wriding a esxpression in maff to sai someting aloong, The, lihnes, of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: along
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

# Chained Comparisons

When writing an expression in math to say something along the lines of
Whn wriding a esxpression in maff to sai someting aloong, The, lihnes, of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Articles like ‘the’ are rarely followed by punctuation. A word may be missing after ‘the’, or the punctuation mark may not be necessary. (THE_PUNCT[1])
Suggestions: The
Rule: https://community.languagetool.org/rule/show/THE_PUNCT?lang=en-US&subId=1
Category: GRAMMAR

# Chained Comparisons

When writing an expression in math to say something along the lines of
Whn wriding a esxpression in maff to sai someting aloong, The, lihnes, of

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Possible spelling mistake found. (MORFOLOGIK_RULE_EN_US)
Suggestions: lines
Rule: https://community.languagetool.org/rule/show/MORFOLOGIK_RULE_EN_US?lang=en-US
Category: TYPOS

@marko-radosavljevic
Copy link
Contributor

marko-radosavljevic commented Jan 14, 2023

It didn't crash, seems to be working well now. ☺️

Definitely like review reporter much more than the check reporter, will change linter to match it at some point as well.

@marko-radosavljevic marko-radosavljevic changed the title test change Language and linter checks testing Jan 14, 2023
@Zabuzard
Copy link
Member Author

the reason i didnt go with that setting it is bc people can bypass it by just resolving the convo. so its impossible to make it "required".

but i think it would be fine anyways

@github-actions
Copy link

This pull request is stale because it has been open 30 days with no activity. Remove stale label, comment or add the valid label or this will be closed in 5 days.

@github-actions github-actions bot added the stale label Feb 14, 2023
@Zabuzard Zabuzard removed the stale label Feb 14, 2023
@Zabuzard Zabuzard added the valid This issue/PR is valid and should be kept open, even if it is not worked on yet. label Feb 14, 2023
@bowbahdoe
Copy link
Collaborator

bowbahdoe commented Mar 15, 2023

Closing this. Linter changes will happen in a new PR

@bowbahdoe bowbahdoe closed this Mar 15, 2023
@Zabuzard Zabuzard deleted the test branch September 22, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

valid This issue/PR is valid and should be kept open, even if it is not worked on yet.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants